Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/implement evntlog refresh #316

Merged
merged 11 commits into from
Sep 21, 2023
Merged

Feature/implement evntlog refresh #316

merged 11 commits into from
Sep 21, 2023

Conversation

acn-dgopa
Copy link
Member

@acn-dgopa acn-dgopa commented Sep 8, 2023 •
edited
Loading

Description

  • Implemented eventlog for refresh
  • implemented eventlog for token exchange

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

91.6% 91.6% Coverage
0.0% 0.0% Duplication

TheTechArch
TheTechArch approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@TheTechArch TheTechArch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
The updated asserts on test will be a good help for being sure it is not changed

@acn-dgopa acn-dgopa merged commit 9dae365 into main Sep 21, 2023
7 of 9 checks passed
@acn-dgopa acn-dgopa deleted the feature/implement-evntlog-refresh branch September 21, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheTechArch TheTechArch TheTechArch approved these changes

@jonkjetiloye jonkjetiloye Awaiting requested review from jonkjetiloye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acn-dgopa @TheTechArch